Add prometheus-prefixed buildinfo endpoint to ruler #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Aug 15, 2022
pracucci
reviewed
Aug 16, 2022
pkg/api/api.go
Outdated
| @@ -290,6 +290,7 @@ func (a *API) RegisterRuler(r *ruler.Ruler) { | |||
|
|
|||
| // List all user rule groups | |||
| a.RegisterRoute("/ruler/rule_groups", http.HandlerFunc(r.ListAllRules), false, true, "GET") | |||
| a.RegisterRoute(path.Join(a.cfg.PrometheusHTTPPrefix, "/api/v1/status/buildinfo"), buildInfoHandler, false, true, "GET") | |||
There was a problem hiding this comment.
Should be moved to RegisterRulerAPI(), which is where Prometheus-compatible APIs are expected to be registered.
There was a problem hiding this comment.
done in 1b3f213
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/add-buildinfo-to-ruler
branch
from
eedf1ab
to
1b3f213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com
What this PR does
Adds the
/prometheus-prefixedbuildinfoendpoint to the ruler. This endpoint is exposed by all other components (querier, query-frontend) that use the<prometheus-http-prefix>, except the ruler.Which issue(s) this PR fixes or relates to
Fixes #2678
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]