Added support to query-tee in front of ruler-query-frontend in the "Remote ruler reads" dashboard #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emote ruler reads" dashboard Signed-off-by: Marco Pracucci <marco@pracucci.com>
colega
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We just merged a PR #2683 to add HTTP-over-gRPC support to query-tee so we can finally use it for tee-ing remote rule evaluation too. When ruler remote evaluation goes through the query-tee, the ruler-query-frontend receive the request over plain HTTP (instead of HTTP-over-gRPC). In this PR I'm adding support for plain HTTP requests to ruler-query-frontend in the "Remote ruler reads" dashboard.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]