Update mimir-prometheus, and remove support for selecting chunk mapper. #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
force-pushed
the
update-mimir-prometheus-remove-old-chunk-mapper
branch
from
bb6f9f9
to
f498cb7
Compare
pracucci
approved these changes
Aug 19, 2022
| # (advanced) The size of the write queue used by the head chunks mapper. Lower | ||
| # values reduce memory utilisation at the cost of potentially higher ingest | ||
| # latency. Value of 0 switches chunks mapper to implementation without a | ||
| # queue. | ||
| # CLI flag: -blocks-storage.tsdb.head-chunks-write-queue-size | ||
| [head_chunks_write_queue_size: <int> | default = 0] |
There was a problem hiding this comment.
I would change the default to 1M. It's what we use at Grafana Labs in prod, and we should upstream for the rest of the world too.
There was a problem hiding this comment.
Done in the latest commit c96cca3
pracucci
approved these changes
Aug 19, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…r we have. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…size to 1000000. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
update-mimir-prometheus-remove-old-chunk-mapper
branch
from
3193dc1
to
6bcfcd9
Compare
pstibrany
added a commit
that referenced
this pull request
Aug 19, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pracucci
pushed a commit
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates mimir-prometheus, which removes support for running with old chunk mapper. This support is also removed from Mimir.
Using new chunk mapper is no longer considered experimental. Option to enable async queue is now "advanced" instead. (Queue is disabled by default, maybe we want to change that?)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]