Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Cache - Latency (old)" panel from the "Mimir / Queries" dashboard #2796

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Aug 22, 2022

What this PR does

In #821 I migrated query-frontend to use the same memcached client as blocks storage, and this changed the metrics exposed by it too. This change was included in Mimir 2.0.0, but I kept querying the old metric in the panel called "Latency (old)" to offer a smoother transition for people migrating from Cortex. Given we're now releasing Mimir 2.3.0 (and so this proposed change will be included in 2.4.0), I think it's time to remove "Latency (old)" panel and just keep the Mimir metric.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…ashboard

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pracucci pracucci merged commit 4a4257f into main Aug 23, 2022
@pracucci pracucci deleted the remove-old-cache-latency-panel branch August 23, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants