Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: stop setting 15s "interval" #2802

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

bboreham
Copy link
Contributor

This appears to stem from missing features and confusion: it was originally set at 1m, and I think that was because Grafana at the time didn't have $__range_interval.

Grafana now lets you configure a scrape interval on your datasource, which is more likely to be correct for your environment than hard-coding it into these dashboards.

Checklist

  • NA Tests updated
  • NA Documentation added
  • CHANGELOG.md updated.

This appears to stem from missing features and confusion: it was
originally set at 1m, and I think that was because Grafana at the time
didn't have `$__range_interval`.

Grafana now lets you configure a scrape interval on your datasource,
which is more likely to be correct for your environment than
hard-coding it into these dashboards.
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit bfcc4b5 into main Aug 24, 2022
@pracucci pracucci deleted the no-dashboard-interval branch August 24, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants