Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query sharding with too large entry query error #2819

Merged
merged 6 commits into from
Aug 26, 2022

Conversation

hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Aug 23, 2022

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #2693.
Make sure we don't retry the 413 error.

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except some naming nitpicks. It would be great to get someone else to review this too though

integration/query_frontend_test.go Outdated Show resolved Hide resolved
integration/query_frontend_test.go Outdated Show resolved Hide resolved
@hi-rustin
Copy link
Contributor Author

Thanks for your review! 💚 💙 💜 💛 ❤️

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a typo

integration/query_frontend_test.go Outdated Show resolved Hide resolved
integration/query_frontend_test.go Outdated Show resolved Hide resolved
@hi-rustin
Copy link
Contributor Author

The conflict has been resolved.

Copy link
Contributor

@colega colega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! :)

@dimitarvdimitrov dimitarvdimitrov merged commit 76abf0e into grafana:main Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceeding gRPC message sizes in querier->query-frontend results in HTTP 500
3 participants