Clean up packaging scripts #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments were not describing the actual behavior of the script which is self explanatory anyway. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
This may have worked any way depending on which shell is actually used but this change is more technically correct and portable as '==' has undefined behavior. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
stevesg
reviewed
Jul 29, 2021
pracucci
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Changes LGTM.
I also agree with Steve about adding the shellcheck to lint Makefile target, so that it will run in CI too. You will need to add shellcheck to the build-image. Since it's not a 1 line change, I'm OK to merge this PR, but I would be glad if you could follow up with the linter thing 🙏
|
I've also created an issue about the follow up work: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Please see individual commit messages for details. This clean up fixes some undefined behavior, removes some confusing comments, lints each script with ShellCheck, and makes indentation consistent.
Besides the correction of the undefined equality operator behavior in posix shells, there is no functionality changed.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]