Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable anonymous usage statistics tracking by default #2939

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does

At Grafana Labs we're dogfooding the anonymous usage statistics since few weeks and, as a next step, I would like to enable it by default. This will be clearly stated in the future 2.4 release notes.

Which issue(s) this PR fixes or relates to

Part of #1815

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@@ -10,7 +10,7 @@
* [CHANGE] Compactor: `-compactor.partial-block-deletion-delay` must either be set to 0 (to disable partial blocks deletion) or a value higher than `4h`. #2787
* [CHANGE] Query-frontend: CLI flag `-query-frontend.align-querier-with-step` has been deprecated. Please use `-query-frontend.align-queries-with-step` instead. #2840
* [CHANGE] Distributor: change the default value of `-distributor.remote-timeout` to `2s` from `20s` and `-distributor.forwarding.request-timeout` to `2s` from `10s` to improve distributor resource usage when ingesters crash. #2728
* [FEATURE] Introduced an experimental anonymous usage statistics tracking (disabled by default), to help Mimir maintainers make better decisions to support the open source community. The tracking system anonymously collects non-sensitive, non-personally identifiable information about the running Mimir cluster, and is disabled by default. #2643 #2662 #2685 #2732 #2733 #2735
* [FEATURE] Introduced an anonymous usage statistics tracking (enabled by default), to help Mimir maintainers make better decisions to support the open source community. The tracking system anonymously collects non-sensitive, non-personally identifiable information about the running Mimir cluster. #2643 #2662 #2685 #2732 #2733 #2735 #2939
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that original changelog entry is in 2.3.0-rc.1. When release-2.3 branch is merged to main again, this entry needs to be split.

Perhaps we should merge release-2.3 branch to main first, and then rebase this PR? WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @treid314. We can't merge release-2.3 to main right now. I will help fixing the CHANGELOG once we'll do the merge next week.

@pstibrany
Copy link
Member

Seems relevant: grafana/agent#2114

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the enable-anonymous-stats-tracking-by-default branch from 46ea94a to c76775a Compare September 15, 2022 14:49
@pracucci pracucci enabled auto-merge (squash) September 15, 2022 14:49
@pracucci pracucci merged commit a8d85bb into main Sep 15, 2022
@pracucci pracucci deleted the enable-anonymous-stats-tracking-by-default branch September 15, 2022 15:04
@pstibrany pstibrany mentioned this pull request Sep 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants