Track OOO setting via anonymous usage statistics #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
reviewed
Sep 12, 2022
pstibrany
approved these changes
Sep 13, 2022
jesusvazquez
approved these changes
Sep 13, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
track-out-of-order-window-setting
branch
from
5b735ca
to
c8ec036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
As requested by @jesusvazquez, in this PR I'm adding the tracking of the number of tenants with OOO ingestion enabled, and their min and max time window setting.
The min/max value is tracked even if 0. Then, when we'll aggregate it on the server side, I will filter out zero values. The reason why I'm also tracking the value of 0 is because the usage statistics currently don't easily allow to conditionally track a value.
Which issue(s) this PR fixes or relates to
Part of #1815
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]