Change -ingester.ring.readiness-check-ring-health default to false #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitarvdimitrov
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
LGTM
We should probably take this into account in the multi-zone work where it runs with maxUnavailable=2 for each zone. @krajorama
For ingesters it's 25 and store gateways is 10, but yes, it's a good idea to default this so we don't have to set in now in helm, thanks |
krajorama
approved these changes
Sep 14, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
change-readiness-check-ring-health-default
branch
from
c34070d
to
3d9928d
Compare
|
Will merge on green. This is a change we can revert quickly if there are objections. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This Slack discussion made me realize Helm is not setting
-ingester.ring.readiness-check-ring-health=falseyet. Given that flag is used in the readiness probe and that we expect ingesters to be deployed as StatefulSet when deployed on Kubernetes, I think disabling it by default may be a better default.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]