Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 400 response while handling streaming remote read #2963

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

leizor
Copy link
Contributor

@leizor leizor commented Sep 15, 2022

What this PR does

This PR fixes a 400 response while handling a streaming remote read request with an "Accept-Encoding" header.

Which issue(s) this PR fixes or relates to

Fixes #2929

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2022

CLA assistant check
All committers have signed the CLA.

@leizor leizor marked this pull request as ready for review September 15, 2022 21:54
@leizor leizor requested a review from a team as a code owner September 15, 2022 21:54
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

CHANGELOG.md Outdated Show resolved Hide resolved
integration/querier_remote_read_test.go Show resolved Hide resolved
@aknuds1 aknuds1 requested a review from a team September 16, 2022 04:17
@aknuds1 aknuds1 added bug Something isn't working component/querier labels Sep 16, 2022
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
@pracucci
Copy link
Collaborator

Thanks @leizor !

@pracucci pracucci enabled auto-merge (squash) September 16, 2022 12:59
@pracucci pracucci merged commit 21d2766 into main Sep 16, 2022
@pracucci pracucci deleted the leizor/mimir/issues/2929 branch September 16, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/querier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't perform streaming remote read
4 participants