Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dskit #2979

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Update dskit #2979

merged 3 commits into from
Sep 23, 2022

Conversation

dimitarvdimitrov
Copy link
Contributor

Pulls in dskit grafana/dskit#201

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com

@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner September 19, 2022 13:31
@colega
Copy link
Contributor

colega commented Sep 20, 2022

Should we mention the change in the changelog?

@dimitarvdimitrov
Copy link
Contributor Author

I wasn't sure what type of entry it should be. I added a bugfix entry because it makes a previously inconsistent behaviour now more consistent.

Pulls in dskit PR 201

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
@dimitarvdimitrov dimitarvdimitrov enabled auto-merge (squash) September 23, 2022 08:05
@dimitarvdimitrov dimitarvdimitrov merged commit e8abd20 into main Sep 23, 2022
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/update-dskit branch September 23, 2022 08:19
@bboreham
Copy link
Contributor

bboreham commented Sep 27, 2022

This PR includes the change much-discussed at #2898.

@bboreham
Copy link
Contributor

Sorry I was confusing with a different change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants