Track the type of ring backend used in the anonymous usage statistics #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
colega
reviewed
Sep 19, 2022
pkg/ingester/ingester.go
Outdated
| @@ -95,6 +95,7 @@ const ( | |||
| sampleOutOfBounds = "sample-out-of-bounds" | |||
|
|
|||
| replicationFactorStatsName = "ingester_replication_factor" | |||
| ringKVStoreStatsName = "ingester_ring_kvstore" | |||
There was a problem hiding this comment.
Confused about this not being ingester_ring_store to mimic the flag, but it's not important so it's ok to me.
There was a problem hiding this comment.
Right. In YAML it's called kvstore, but it's called store in CLI flag. I don't have a preference neither. I can rename it to *_store.
pstibrany
approved these changes
Sep 19, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We would like to learn more about the type of KV store used for the ring. I propose to track it only for the ingesters which is the most critical, and it's unlikely that people use a different backend for different rings.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]