-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropped metric panic with OTLP #3040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
fix-otlp-dropped-counts
branch
from
September 26, 2022 10:00
b791d94
to
5034a31
Compare
Tests are pending Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
fix-otlp-dropped-counts
branch
from
September 26, 2022 10:03
5034a31
to
d5d08ec
Compare
gouthamve
force-pushed
the
fix-otlp-dropped-counts
branch
from
September 26, 2022 11:05
f751aa5
to
41e2cb6
Compare
aknuds1
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (see nit)!
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
gouthamve
force-pushed
the
fix-otlp-dropped-counts
branch
from
September 26, 2022 11:45
8600ea0
to
8529130
Compare
aknuds1
added a commit
that referenced
this pull request
Sep 26, 2022
* Fix dropped metric panic with OTLP Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
2 tasks
aknuds1
added a commit
that referenced
this pull request
Sep 26, 2022
andyasp
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Fix dropped metric panic with OTLP Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3040-to-release-2.3 origin/release-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 5c11f6b9933e0fc60994f8d09316dd86ea39ab0d
# Push it to GitHub
git push --set-upstream origin backport-3040-to-release-2.3
git switch main
# Remove the local backport branch
git branch -D backport-3040-to-release-2.3 Then, create a pull request where the |
treid314
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Fix dropped metric panic with OTLP Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> (cherry picked from commit 5c11f6b)
treid314
pushed a commit
that referenced
this pull request
Sep 26, 2022
* Fix dropped metric panic with OTLP Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> (cherry picked from commit 5c11f6b) Co-authored-by: Goutham Veeramachaneni <gouthamve@gmail.com>
sysedwinistrator
pushed a commit
to sysedwinistrator/mimir
that referenced
this pull request
Nov 21, 2022
* Fix dropped metric panic with OTLP Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes or relates to
Fixes #3037
Checklist
Documentation addedCHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]