Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disk space utilization panels when deployment_type=baremetal #3173

Merged

Conversation

wilfriedroset
Copy link
Collaborator

What this PR does

Fix legend showing persistentvolumeclaim when using deployment_type=baremetal for Disk space utilization panels

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@wilfriedroset wilfriedroset requested a review from a team as a code owner October 10, 2022 09:08
…ployment_type=baremetal` for `Disk space utilization` panels

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
@wilfriedroset wilfriedroset force-pushed the dashboard-containerDiskSpaceUtilization branch from d3d64ea to 9df4b10 Compare October 10, 2022 09:08
Copy link
Contributor

@colega colega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@colega colega enabled auto-merge (squash) October 10, 2022 09:10
@colega colega merged commit 48143f0 into grafana:main Oct 10, 2022
@@ -8,6 +8,7 @@
* [BUGFIX] Flusher: Add `Overrides` as a dependency to prevent panics when starting with `-target=flusher`. #3151

### Mixin
* [BUGIX] Dashboards: Fix legend showing `persistentvolumeclaim` when using `deployment_type=baremetal` for `Disk space utilization` panels. #3173
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUGIX

Oops, BUGFIX

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I've cleanup after myself in this PR
#3184

@wilfriedroset wilfriedroset mentioned this pull request Oct 11, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants