-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixin: ruler emote eval failing alert #3177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d9c77a
to
145b900
Compare
osg-grafana
reviewed
Oct 10, 2022
osg-grafana
reviewed
Oct 10, 2022
osg-grafana
reviewed
Oct 10, 2022
osg-grafana
reviewed
Oct 10, 2022
osg-grafana
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking with feedback
pracucci
reviewed
Nov 3, 2022
346bcb4
to
aafbca3
Compare
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
aafbca3
to
8967203
Compare
pracucci
reviewed
Nov 3, 2022
Co-authored-by: Marco Pracucci <marco@pracucci.com>
pracucci
reviewed
Nov 3, 2022
b125a42
to
13a267c
Compare
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
13a267c
to
0f8fdc9
Compare
pracucci
reviewed
Nov 3, 2022
pracucci
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Nov 4, 2022
* mixin: added ruler remote eval alert Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * make use of jobMatcher mixin Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * Update operations/mimir-mixin/alerts/alerts-utils.libsonnet Co-authored-by: Marco Pracucci <marco@pracucci.com> * rebuild mixin Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * Update operations/mimir-mixin/alerts/alerts-utils.libsonnet Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Nov 4, 2022
* mixin: added ruler remote eval alert Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * make use of jobMatcher mixin Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * Update operations/mimir-mixin/alerts/alerts-utils.libsonnet Co-authored-by: Marco Pracucci <marco@pracucci.com> * rebuild mixin Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> * Update operations/mimir-mixin/alerts/alerts-utils.libsonnet Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental
RulerRemoteEvaluationFailing
alert has proven to work correctly at the ops cluster.This PR moves the alert definition to upstream.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]