Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: ruler emote eval failing alert #3177

Merged
merged 6 commits into from
Nov 3, 2022

Conversation

ortuman
Copy link
Contributor

@ortuman ortuman commented Oct 10, 2022

The experimental RulerRemoteEvaluationFailing alert has proven to work correctly at the ops cluster.

This PR moves the alert definition to upstream.

What this PR does

Which issue(s) this PR fixes or relates to

Fixes N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@ortuman ortuman added enhancement New feature or request monitoring/alerts labels Oct 10, 2022
@ortuman ortuman force-pushed the ortuman/ruler-remove-eval-failing-alert branch 7 times, most recently from 3d9c77a to 145b900 Compare October 10, 2022 11:10
@ortuman ortuman marked this pull request as ready for review October 10, 2022 11:31
@ortuman ortuman requested review from osg-grafana and a team as code owners October 10, 2022 11:31
Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking with feedback

@ortuman ortuman force-pushed the ortuman/ruler-remove-eval-failing-alert branch from 346bcb4 to aafbca3 Compare November 3, 2022 11:22
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
@ortuman ortuman force-pushed the ortuman/ruler-remove-eval-failing-alert branch from aafbca3 to 8967203 Compare November 3, 2022 11:28
@ortuman ortuman requested a review from pracucci November 3, 2022 13:41
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@ortuman ortuman force-pushed the ortuman/ruler-remove-eval-failing-alert branch from b125a42 to 13a267c Compare November 3, 2022 15:40
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
@ortuman ortuman force-pushed the ortuman/ruler-remove-eval-failing-alert branch from 13a267c to 0f8fdc9 Compare November 3, 2022 15:46
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pracucci pracucci enabled auto-merge (squash) November 3, 2022 16:11
@pracucci pracucci merged commit 453ae5a into main Nov 3, 2022
@pracucci pracucci deleted the ortuman/ruler-remove-eval-failing-alert branch November 3, 2022 16:31
masonmei pushed a commit to udmire/mimir that referenced this pull request Nov 4, 2022
* mixin: added ruler remote eval alert

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>

* make use of jobMatcher mixin

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>

* Update operations/mimir-mixin/alerts/alerts-utils.libsonnet

Co-authored-by: Marco Pracucci <marco@pracucci.com>

* rebuild mixin

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>

* Update operations/mimir-mixin/alerts/alerts-utils.libsonnet

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
masonmei pushed a commit to udmire/mimir that referenced this pull request Nov 4, 2022
* mixin: added ruler remote eval alert

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>

* make use of jobMatcher mixin

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>

* Update operations/mimir-mixin/alerts/alerts-utils.libsonnet

Co-authored-by: Marco Pracucci <marco@pracucci.com>

* rebuild mixin

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>

* Update operations/mimir-mixin/alerts/alerts-utils.libsonnet

Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request monitoring/alerts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants