Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copyblocks: copy no-compact markers and optimize min time filter check #3268

Merged
merged 3 commits into from Oct 21, 2022
Merged

copyblocks: copy no-compact markers and optimize min time filter check #3268

merged 3 commits into from Oct 21, 2022

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Oct 20, 2022 •
edited

What this PR does

In this PR:

  • Add support to copy no-compact global markers
  • Optimize min time filter check to run the check on the block creation time before checking the meta.json file

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

pstibrany
pstibrany approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, thanks.

tools/copyblocks/main.go Outdated Show resolved Hide resolved
Base automatically changed from import-blocks-copy to main October 21, 2022 12:25
@pracucci
copyblocks: copy no-compact markers and optimize min time filter check
4f1a9e2 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci
Add CHANGELOG entry
9bb47be 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci force-pushed the add-no-compact-marker-support-to-copyblocks branch from b7a40b5 to 9bb47be Compare October 21, 2022 13:19
@pracucci
Address review feedback
35ebd2e 
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review October 21, 2022 13:21
@pracucci pracucci requested a review from a team as a code owner October 21, 2022 13:21
@pracucci pracucci enabled auto-merge (squash) October 21, 2022 13:22
@pracucci pracucci merged commit 1612373 into main Oct 21, 2022
@pracucci pracucci deleted the add-no-compact-marker-support-to-copyblocks branch October 21, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstibrany pstibrany pstibrany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pracucci @pstibrany