Include tenant in forwarded requests #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
replay
reviewed
Oct 21, 2022
| @@ -432,6 +434,7 @@ func (f *forwarder) submitForwardingRequest(ctx context.Context, endpoint string | |||
| req.requestWg = requestWg | |||
|
|
|||
| // Target endpoint and TimeSeries to forward. | |||
| req.user = user | |||
There was a problem hiding this comment.
the comment above this line is now strange because it only talks about endpoint/timeseries
There was a problem hiding this comment.
I've changed the comment to "Request parameters". WDYT?
replay
approved these changes
Oct 21, 2022
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR modifies Distributor's forwarding feature to always include
X-Scope-OrgIdheader with tenant when forwarding requests to the configured endpoint.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]