distributor: Wrap errors from pushing to ingesters #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
3 times, most recently
from
a62715f
to
4be2147
Compare
aknuds1
changed the title
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
4be2147
to
56905ef
Compare
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
56905ef
to
ad98691
Compare
Logiraptor
reviewed
Oct 26, 2022
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
force-pushed
the
chore/distributor-wrap-push-error
branch
from
174fea7
to
f7cec83
Compare
Logiraptor
approved these changes
Oct 27, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Nov 4, 2022
* distributor: Wrap errors from pushing to ingesters * distributor: Return httpgrpc error on timeout Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Nov 4, 2022
* distributor: Wrap errors from pushing to ingesters * distributor: Return httpgrpc error on timeout Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In the distributor component, wrap errors stemming from calling the push gRPC method on ingesters, making sure to maintain result status codes. If an errors stems from a timeout, that gets turned into an
httpgrpcerror with status code 500 and a specific message.I hope this will be useful in diagnosing write requests timing out in the ingester component (e.g. due to CPU starvation).
Which issue(s) this PR fixes or relates to
Fixes #3214
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]