Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use imperative for "Deploy with jsonnet" docs #3332

Merged
merged 2 commits into from Oct 31, 2022

Conversation

colega
Copy link
Contributor

@colega colega commented Oct 28, 2022

What this PR does

Ref: #1663

This renames the sections under "Deploy with jsonnet" (and that section itself) to use imperative instead of gerunds.

Aliases have been added for previous names.

Which issue(s) this PR fixes or relates to

Ref: #1663

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Ref: #1663

This renames the sections under "Deploy with jsonnet" (and that section
itself) to use imperative instead of gerunds.

Aliases have been added for previous names.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega requested review from osg-grafana and a team as code owners October 28, 2022 13:27
@osg-grafana osg-grafana added the type/docs Improvements or additions to documentation label Oct 28, 2022
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega merged commit 6dca855 into main Oct 31, 2022
@colega colega deleted the use-imperative-for-deploy-with-jsonnet-docs branch October 31, 2022 11:10
masonmei pushed a commit to udmire/mimir that referenced this pull request Nov 4, 2022
* Use imperative for "Deploy with jsonnet" docs

Ref: grafana#1663

This renames the sections under "Deploy with jsonnet" (and that section
itself) to use imperative instead of gerunds.

Aliases have been added for previous names.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Fix skipped heading

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
masonmei pushed a commit to udmire/mimir that referenced this pull request Nov 4, 2022
* Use imperative for "Deploy with jsonnet" docs

Ref: grafana#1663

This renames the sections under "Deploy with jsonnet" (and that section
itself) to use imperative instead of gerunds.

Aliases have been added for previous names.

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Fix skipped heading

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants