Align the -server.http-write-timeout with -querier.timeout to 2m
#3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-rustin
force-pushed
the
rustin-patch-timeout
branch
from
1e5c213
to
ebe2381
Compare
dimitarvdimitrov
approved these changes
Nov 2, 2022
pracucci
approved these changes
Nov 3, 2022
Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Nov 4, 2022
…rafana#3346) * Align the `-server.http-write-timeout` with `-querier.timeout` to 2m * Add a validation for these values * Update docs * Update CHANGELOG.md * move it into a higher level package * Apply suggestions from code review * Reordered CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Nov 4, 2022
…rafana#3346) * Align the `-server.http-write-timeout` with `-querier.timeout` to 2m * Add a validation for these values * Update docs * Update CHANGELOG.md * move it into a higher level package * Apply suggestions from code review * Reordered CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
3 tasks
colega
added a commit
that referenced
this pull request
Jan 3, 2023
* Remove 'server.http-write-timeout' from jsonnet This option now defaults to 2m: #3346 And also it's validated to not to be lower than querier.timeout, so having this 1m value breaks the jsonnet. Fixes #3824 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * make check-jsonnet-tests Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Remove helm-jsonnet ignore Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Align the
-server.http-write-timeoutwith-querier.timeoutto 2m. Add validation for these values.Which issue(s) this PR fixes or relates to
Fixes #3248
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]