Jsonnet: add support for read-write deployment mode #3379
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…evert it when read-write deployment mode is enabled Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
|
||
| storage_backend: 's3', | ||
| blocks_storage_bucket_name: 'blocks-bucket', | ||
| bucket_index_enabled: true, |
There was a problem hiding this comment.
Nit: this is the default value, I'd skip it.
There was a problem hiding this comment.
Agree. Will do in a separate PR, cause affects other tests too.
| storage_backend: 's3', | ||
| blocks_storage_bucket_name: 'blocks-bucket', | ||
| bucket_index_enabled: true, | ||
| query_scheduler_enabled: true, |
There was a problem hiding this comment.
Same, this is the default value, I'd also skip it.
There was a problem hiding this comment.
Agree. Will do in a separate PR, cause affects other tests too.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
| check_memberlist_ring: if !$._config.read_write_deployment_enabled || $._config.memberlist_ring_enabled then null else | ||
| error 'please set memberlist_ring_enabled to true when using Mimir read-write deployment mode', | ||
|
|
||
| // Uninstall resources used by microservices deployment mode. |
There was a problem hiding this comment.
I guess some day we'll need to either include one or another, instead of uninstalling them.
There was a problem hiding this comment.
Right. Is this significantly different enough that it warrants a whole new jsonnet project? eg operations/mimir-read-write-deployment? Especially since switching is a destructive operation.
There was a problem hiding this comment.
I don't want separate jsonnet projects. Two projects means doing changes in 2 places every time and it's harder to keep consistency between the two. However I agree with Oleg that a follow up work should be creating the microservices exported resources (deployments, statefulsets, ...) conditionally instead of uninstalling them. I will add as a TODO to my work.
| // Creates a headless service for the per-zone mimir-backends StatefulSet. We don't use it | ||
| // but we need to create it anyway because it's responsible for the network identity of | ||
| // the StatefulSet pods. For more information, see: | ||
| // https://v1-18.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#statefulset-v1-apps |
There was a problem hiding this comment.
Nit: this link doesn't seem to work anymore.
|
The more I look at this the more I think it should be its own jsonnet lib. Thoughts? |
|
I think there will be too much overlap among both (how things are configured,which are the valid options, etc., it's all the same), I'd keep them in the same package. |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
* Jsonnet: add support for read-write deployment mode Signed-off-by: Marco Pracucci <marco@pracucci.com> * Always import overrides-exporter.libsonnet so that we can correctly revert it when read-write deployment mode is enabled Signed-off-by: Marco Pracucci <marco@pracucci.com> * Disable overrides-exporter when read-write deployment mode is enabled Signed-off-by: Marco Pracucci <marco@pracucci.com> * Clarified the CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed K8S reference link Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com>
What this PR does
In this PR I'm upstreaming the read-write deployment mode jsonnet setup we're using at Grafana Labs. To make the
jsonnet overrides correctly work for the overrides-exporter, I've changed jsonnet to always import
overrides-exporter.libsonnetand conditionally enable it using a new configuration option (this approach follows how other optional components are enabled too, so it's also more consistent with the rest of jsonnet).Which issue(s) this PR fixes or relates to
Part of #3364
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]