Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persistence of rulegroup evaluation delay. #3392

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

pstibrany
Copy link
Member

What this PR does

Fixes problem with persisting evaluation delay of rulegroup.

Which issue(s) this PR fixes or relates to

Fixes #3357

Checklist

  • Tests updated
  • [na] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany requested a review from a team as a code owner November 4, 2022 11:58
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing it

@pstibrany pstibrany merged commit 0d0070c into main Nov 4, 2022
@pstibrany pstibrany deleted the fix-rule-evaluation-delay branch November 4, 2022 13:32
@pstibrany
Copy link
Member Author

Thanks for reviews!

masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
* Fix persistence of rulegroup evaluation delay.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation delay set per group is not stored or used by Mimir
3 participants