Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to file that no longer exists in contributing guide. #3404

Merged
merged 1 commit into from Nov 8, 2022

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Nov 8, 2022

What this PR does

The contributing guide refers to how-to-run-website-locally.md, but this file was removed in #772.

It seems that make docs is the easiest way to run the website locally now.

Which issue(s) this PR fixes or relates to

n/a

Checklist

  • [n/a] Tests updated
  • [n/a] Documentation added
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@charleskorn charleskorn requested review from osg-grafana and a team as code owners November 8, 2022 05:14
@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci enabled auto-merge (squash) November 8, 2022 05:21
@pracucci pracucci merged commit 0124ab7 into main Nov 8, 2022
@pracucci pracucci deleted the remove-outdated-reference-in-contributing-guide branch November 8, 2022 05:29
masonmei pushed a commit to udmire/mimir that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants