Use []byte when reading postings offset table #3436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
TL;DR: don't try to be too clever, compiler already is.
In a previous PR I changed the labels reading to use an unsafe string backed by the original buffer slice, and then copying those strings manually when needed to store them.
It happens that those optimizations already exist in the compiler, and looking up
map[string([]byte{...})]
does not allocate as string.Actually, I was surprised because benchmarks look even better, with even less allocations than when using the unsafe string.
Which issue(s) this PR fixes or relates to
Followup on #3397
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]