mixin: configurable namespace label, job label, and job prefix #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Nov 21, 2022
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
osg-grafana
reviewed
Nov 24, 2022
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
pracucci
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Great job, LGTM! I will let @osg-grafana follow up with doc review. I've also marked the PR "ready for review" since it was still a draft.
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
osg-grafana
reviewed
Nov 24, 2022
docs/sources/operators-guide/monitor-grafana-mimir/requirements.md
Outdated
Show resolved
Hide resolved
osg-grafana
suggested changes
Nov 24, 2022
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
|
Thanks @osg-grafana and @pracucci for your help to get this merged! |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…na#3482) * mixin: add option for custom namespace label name * mixin: add option for custom job prefix * mixin: add option for custom job label * mimir-mixin: use named placeholder Co-authored-by: Marco Pracucci <marco@pracucci.com> * mimir-mixin: use named placeholder Co-authored-by: Marco Pracucci <marco@pracucci.com> * mimir-mixin: update documentation * mixin: update CHANGELOG.md * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * mimir-mixin: improve documentation Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com> * Run 'make doc' to format markdown Signed-off-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes labels used for namespace and job selection, and the prefix used in the job selection configurable
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]