alerts: Fix MimirIngesterHasNotShippedBlocks for other deployment modes #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Dec 2, 2022
pracucci
reviewed
Dec 5, 2022
pracucci
reviewed
Dec 5, 2022
jhesketh
force-pushed
the
read-write-deployment/alerts/MimirIngesterHasNotShippedBlocks
branch
2 times, most recently
from
70adca1
to
845db53
Compare
pracucci
reviewed
Dec 6, 2022
pstibrany
approved these changes
Dec 6, 2022
This fixes the job regex for monolithic and read-write deployment modes for MimirIngesterHasNotShippedBlocks and MimirIngesterHasNotShippedBlocksSinceStart
Use the new mimir_ingester_shipper_bucket_last_successful_upload_time metric which only counts for ingester shipper rather than any uploaded blocks.
Co-authored-by: Marco Pracucci <marco@pracucci.com>
jhesketh
force-pushed
the
read-write-deployment/alerts/MimirIngesterHasNotShippedBlocks
branch
from
ed98e87
to
aa350a6
Compare
pracucci
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Logic changes LGTM!
Some suggestions to unit test it:
- You could add the assertions to the test
TestShipper(). - Since we can't assert on the exact timestamp (it would be unreliable) we can't assert on the actual
/metricsoutput. However, you can get the metric value usingtestutil.ToFloat64(s.metrics. lastSuccessfulUploadTime)and assert on a value with a delta toleration (e.g. now +/- 2 seconds). You can assert value is 0 before the 1st upload, then updated afterSync()is called for the first time.
…sNotShippedBlocks # Conflicts: # CHANGELOG.md
pracucci
approved these changes
Dec 13, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…es (grafana#3627) * alerts: Fix MimirIngesterHasNotShippedBlocks for other deployment modes This fixes the job regex for monolithic and read-write deployment modes for MimirIngesterHasNotShippedBlocks and MimirIngesterHasNotShippedBlocksSinceStart * Update CHANGELOG * Add new metric for tracking last shipped block time * Update IngesterHasNotShippedBlocks to use new metric Use the new mimir_ingester_shipper_bucket_last_successful_upload_time metric which only counts for ingester shipper rather than any uploaded blocks. * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG * Update alert to use new metric * Fix gauge type * Update helm test * Group code a bit cleaner * Add test for new metric * Apply suggestions from code review Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This fixes the job regex for monolithic and read-write deployment modes for MimirIngesterHasNotShippedBlocks and MimirIngesterHasNotShippedBlocksSinceStart
Which issue(s) this PR fixes or relates to
Partial fixes #3366
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]