Store gateway mmap removal: use a shared pool of buffers across all Decbuf instances #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in a small improvement in performance and heap consumption: name old time/op new time/op delta NewStreamBinaryReader/20Names100Values-10 758µs ± 7% 726µs ± 1% ~ (p=0.111 n=5+4) NewStreamBinaryReader/20Names500Values-10 2.12ms ± 4% 2.15ms ± 4% ~ (p=0.548 n=5+5) NewStreamBinaryReader/20Names1000Values-10 3.49ms ± 2% 3.44ms ± 2% ~ (p=0.222 n=5+5) NewStreamBinaryReader/50Names100Values-10 1.54ms ± 4% 1.51ms ± 5% ~ (p=0.421 n=5+5) NewStreamBinaryReader/50Names500Values-10 4.33ms ± 1% 4.39ms ± 8% ~ (p=1.000 n=5+5) NewStreamBinaryReader/50Names1000Values-10 7.88ms ± 3% 7.84ms ± 3% ~ (p=0.690 n=5+5) NewStreamBinaryReader/100Names100Values-10 2.73ms ± 5% 2.57ms ± 5% -6.15% (p=0.032 n=5+5) NewStreamBinaryReader/100Names500Values-10 8.12ms ± 3% 8.02ms ± 2% ~ (p=0.548 n=5+5) NewStreamBinaryReader/100Names1000Values-10 15.3ms ± 3% 14.8ms ± 1% -3.43% (p=0.016 n=5+5) NewStreamBinaryReader/200Names100Values-10 4.87ms ± 7% 4.84ms ± 4% ~ (p=0.841 n=5+5) NewStreamBinaryReader/200Names500Values-10 15.9ms ± 2% 15.9ms ± 1% ~ (p=1.000 n=5+5) NewStreamBinaryReader/200Names1000Values-10 30.0ms ± 2% 30.2ms ± 3% ~ (p=1.000 n=5+5) name old alloc/op new alloc/op delta NewStreamBinaryReader/20Names100Values-10 3.36MB ± 0% 3.35MB ± 0% -0.29% (p=0.000 n=5+4) NewStreamBinaryReader/20Names500Values-10 4.00MB ± 0% 3.99MB ± 0% -0.25% (p=0.016 n=5+4) NewStreamBinaryReader/20Names1000Values-10 4.80MB ± 0% 4.79MB ± 0% -0.21% (p=0.008 n=5+5) NewStreamBinaryReader/50Names100Values-10 3.63MB ± 0% 3.62MB ± 0% -0.27% (p=0.016 n=4+5) NewStreamBinaryReader/50Names500Values-10 5.21MB ± 0% 5.20MB ± 0% -0.19% (p=0.008 n=5+5) NewStreamBinaryReader/50Names1000Values-10 7.23MB ± 0% 7.22MB ± 0% -0.14% (p=0.008 n=5+5) NewStreamBinaryReader/100Names100Values-10 4.08MB ± 0% 4.07MB ± 0% -0.24% (p=0.008 n=5+5) NewStreamBinaryReader/100Names500Values-10 7.24MB ± 0% 7.23MB ± 0% -0.14% (p=0.008 n=5+5) NewStreamBinaryReader/100Names1000Values-10 11.3MB ± 0% 11.3MB ± 0% -0.09% (p=0.029 n=4+4) NewStreamBinaryReader/200Names100Values-10 4.97MB ± 0% 4.96MB ± 0% -0.20% (p=0.008 n=5+5) NewStreamBinaryReader/200Names500Values-10 11.6MB ± 0% 11.6MB ± 0% -0.08% (p=0.008 n=5+5) NewStreamBinaryReader/200Names1000Values-10 20.1MB ± 0% 20.1MB ± 0% -0.05% (p=0.016 n=4+5) name old allocs/op new allocs/op delta NewStreamBinaryReader/20Names100Values-10 6.23k ± 0% 6.22k ± 0% -0.11% (p=0.029 n=4+4) NewStreamBinaryReader/20Names500Values-10 30.3k ± 0% 30.3k ± 0% -0.02% (p=0.029 n=4+4) NewStreamBinaryReader/20Names1000Values-10 60.3k ± 0% 60.3k ± 0% -0.01% (p=0.029 n=4+4) NewStreamBinaryReader/50Names100Values-10 15.5k ± 0% 15.5k ± 0% -0.05% (p=0.029 n=4+4) NewStreamBinaryReader/50Names500Values-10 75.6k ± 0% 75.6k ± 0% ~ (p=0.079 n=4+5) NewStreamBinaryReader/50Names1000Values-10 151k ± 0% 151k ± 0% -0.00% (p=0.029 n=4+4) NewStreamBinaryReader/100Names100Values-10 31.0k ± 0% 31.0k ± 0% -0.02% (p=0.000 n=4+5) NewStreamBinaryReader/100Names500Values-10 151k ± 0% 151k ± 0% -0.00% (p=0.000 n=5+4) NewStreamBinaryReader/100Names1000Values-10 301k ± 0% 301k ± 0% -0.00% (p=0.016 n=4+5) NewStreamBinaryReader/200Names100Values-10 61.9k ± 0% 61.9k ± 0% -0.01% (p=0.008 n=5+5) NewStreamBinaryReader/200Names500Values-10 302k ± 0% 302k ± 0% -0.00% (p=0.008 n=5+5) NewStreamBinaryReader/200Names1000Values-10 602k ± 0% 602k ± 0% -0.00% (p=0.016 n=5+4)
This was referenced Dec 12, 2022
colega
reviewed
Dec 12, 2022
colega
approved these changes
Dec 12, 2022
56quarters
reviewed
Dec 12, 2022
charleskorn
force-pushed
the
charleskorn/shared-buffer-pool
branch
from
8730a9b
to
dd02896
Compare
charleskorn
force-pushed
the
charleskorn/shared-buffer-pool
branch
from
dd02896
to
9f7d5c9
Compare
56quarters
approved these changes
Dec 13, 2022
3 tasks
56quarters
added a commit
that referenced
this pull request
Dec 13, 2022
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…ecbuf instances (grafana#3691) * Use a shared pool of buffers across all DecbufFactory instances. This results in a small improvement in performance and heap consumption: name old time/op new time/op delta NewStreamBinaryReader/20Names100Values-10 758µs ± 7% 726µs ± 1% ~ (p=0.111 n=5+4) NewStreamBinaryReader/20Names500Values-10 2.12ms ± 4% 2.15ms ± 4% ~ (p=0.548 n=5+5) NewStreamBinaryReader/20Names1000Values-10 3.49ms ± 2% 3.44ms ± 2% ~ (p=0.222 n=5+5) NewStreamBinaryReader/50Names100Values-10 1.54ms ± 4% 1.51ms ± 5% ~ (p=0.421 n=5+5) NewStreamBinaryReader/50Names500Values-10 4.33ms ± 1% 4.39ms ± 8% ~ (p=1.000 n=5+5) NewStreamBinaryReader/50Names1000Values-10 7.88ms ± 3% 7.84ms ± 3% ~ (p=0.690 n=5+5) NewStreamBinaryReader/100Names100Values-10 2.73ms ± 5% 2.57ms ± 5% -6.15% (p=0.032 n=5+5) NewStreamBinaryReader/100Names500Values-10 8.12ms ± 3% 8.02ms ± 2% ~ (p=0.548 n=5+5) NewStreamBinaryReader/100Names1000Values-10 15.3ms ± 3% 14.8ms ± 1% -3.43% (p=0.016 n=5+5) NewStreamBinaryReader/200Names100Values-10 4.87ms ± 7% 4.84ms ± 4% ~ (p=0.841 n=5+5) NewStreamBinaryReader/200Names500Values-10 15.9ms ± 2% 15.9ms ± 1% ~ (p=1.000 n=5+5) NewStreamBinaryReader/200Names1000Values-10 30.0ms ± 2% 30.2ms ± 3% ~ (p=1.000 n=5+5) name old alloc/op new alloc/op delta NewStreamBinaryReader/20Names100Values-10 3.36MB ± 0% 3.35MB ± 0% -0.29% (p=0.000 n=5+4) NewStreamBinaryReader/20Names500Values-10 4.00MB ± 0% 3.99MB ± 0% -0.25% (p=0.016 n=5+4) NewStreamBinaryReader/20Names1000Values-10 4.80MB ± 0% 4.79MB ± 0% -0.21% (p=0.008 n=5+5) NewStreamBinaryReader/50Names100Values-10 3.63MB ± 0% 3.62MB ± 0% -0.27% (p=0.016 n=4+5) NewStreamBinaryReader/50Names500Values-10 5.21MB ± 0% 5.20MB ± 0% -0.19% (p=0.008 n=5+5) NewStreamBinaryReader/50Names1000Values-10 7.23MB ± 0% 7.22MB ± 0% -0.14% (p=0.008 n=5+5) NewStreamBinaryReader/100Names100Values-10 4.08MB ± 0% 4.07MB ± 0% -0.24% (p=0.008 n=5+5) NewStreamBinaryReader/100Names500Values-10 7.24MB ± 0% 7.23MB ± 0% -0.14% (p=0.008 n=5+5) NewStreamBinaryReader/100Names1000Values-10 11.3MB ± 0% 11.3MB ± 0% -0.09% (p=0.029 n=4+4) NewStreamBinaryReader/200Names100Values-10 4.97MB ± 0% 4.96MB ± 0% -0.20% (p=0.008 n=5+5) NewStreamBinaryReader/200Names500Values-10 11.6MB ± 0% 11.6MB ± 0% -0.08% (p=0.008 n=5+5) NewStreamBinaryReader/200Names1000Values-10 20.1MB ± 0% 20.1MB ± 0% -0.05% (p=0.016 n=4+5) name old allocs/op new allocs/op delta NewStreamBinaryReader/20Names100Values-10 6.23k ± 0% 6.22k ± 0% -0.11% (p=0.029 n=4+4) NewStreamBinaryReader/20Names500Values-10 30.3k ± 0% 30.3k ± 0% -0.02% (p=0.029 n=4+4) NewStreamBinaryReader/20Names1000Values-10 60.3k ± 0% 60.3k ± 0% -0.01% (p=0.029 n=4+4) NewStreamBinaryReader/50Names100Values-10 15.5k ± 0% 15.5k ± 0% -0.05% (p=0.029 n=4+4) NewStreamBinaryReader/50Names500Values-10 75.6k ± 0% 75.6k ± 0% ~ (p=0.079 n=4+5) NewStreamBinaryReader/50Names1000Values-10 151k ± 0% 151k ± 0% -0.00% (p=0.029 n=4+4) NewStreamBinaryReader/100Names100Values-10 31.0k ± 0% 31.0k ± 0% -0.02% (p=0.000 n=4+5) NewStreamBinaryReader/100Names500Values-10 151k ± 0% 151k ± 0% -0.00% (p=0.000 n=5+4) NewStreamBinaryReader/100Names1000Values-10 301k ± 0% 301k ± 0% -0.00% (p=0.016 n=4+5) NewStreamBinaryReader/200Names100Values-10 61.9k ± 0% 61.9k ± 0% -0.01% (p=0.008 n=5+5) NewStreamBinaryReader/200Names500Values-10 302k ± 0% 302k ± 0% -0.00% (p=0.008 n=5+5) NewStreamBinaryReader/200Names1000Values-10 602k ± 0% 602k ± 0% -0.00% (p=0.016 n=5+4) * Move buffer pool management into FileReader. * Add note about how pooled buffers are cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Previously, we created a separate pool of
bufio.Readers for eachDecbufFactory(and we create a new factory for each index-header). This is unnecessary - we can share the same pool of buffers across allDecbufs.Which issue(s) this PR fixes or relates to
#3465
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]