Please ignore, running integration tests for sparse histograms #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
Signed-off-by: Levi Harrison <git@leviharrison.dev>
* Fix mergeStream Define semantics and implement a version that passes current tests. Todo add tests with histograms. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Add chunk batch stream tests for histograms and fix logic Needed to add code to be able to split Batches when type is changing. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Rephrase assertions in chunk_test.go Should not assert for x == y , use Equal(x,y) instead. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Mock values type in chunk_test.go mockIterator Otherwise the tests fail since they assert on the returned type. On the other hand, no need to mock values themselves since the iterator tests only care about timestampts and lenghts. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Make linter happy, do early returns Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Since we don't forward histograms any more this is not needed and the deep copy actually would take more time to develop. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
…format (#4269) * Add (currently failing) integration test for querying native histograms with new query result payload format enabled. * Add support for decoding vector values containing native histograms. * Add support for decoding matrix values containing native histograms. * Add benchmark for decoding protobuf format. * Fix remaining tests. * Always enable histograms in integration test.
* Add native histogram support for recording rules * Improve TestPusherAppendable and add native histograms to it Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
instead of hacking copyFlags Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Fixes a couple of TODOs Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
…thods to compare histograms in mimirpb format?
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
zenador
force-pushed
the
sparsehistogram-goes-boom
branch
2 times, most recently
from
e70611c
to
1cb3240
Compare
…f test histograms
zenador
force-pushed
the
sparsehistogram-goes-boom
branch
from
1cb3240
to
67fa1f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ignore, not for merging, just seeing integration test results.