New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store gateway spends most of the time waiting to load series and chun… #3927
Conversation
…ks. During that waiting time, a context.Canceled error might occur. The latter must not be handled as a consistency check, but should be propagated as context.Canceled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! (I'd recommend reviewing with whitespace changes ignored).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nicely done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing my comments
@duricanikolic I've noticed that this consistency check can also show up when a Ruler runs an expensive rule against the SGW that results in an response from the SGW with Conversation: https://grafana.slack.com/archives/C039863E8P7/p1675357321799079 |
@pracucci, @56quarters What do you think about this? |
What this PR does
Store gateway spends most of the time waiting to load series and chunks. During that waiting time, a context.Canceled error might occur. The latter must not be handled as a consistency check, but should be propagated as context.Canceled.
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]