Deprecate readiness-check-ring-health config option #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
force-pushed
the
readinesscheck
branch
from
263f19c
to
7aec58e
Compare
pstibrany
reviewed
Mar 8, 2023
pstibrany
reviewed
Mar 8, 2023
ying-jeanne
commented
Mar 8, 2023
pkg/ingester/ingester_ring.go
Outdated
| @@ -119,7 +125,7 @@ func (cfg *RingConfig) ToRingConfig() ring.Config { | |||
|
|
|||
| // ToLifecyclerConfig returns a ring.LifecyclerConfig based on the ingester | |||
| // ring config. | |||
| func (cfg *RingConfig) ToLifecyclerConfig() ring.LifecyclerConfig { | |||
| func (cfg *RingConfig) ToLifecyclerConfig(logger log.Logger) ring.LifecyclerConfig { | |||
There was a problem hiding this comment.
I have put the check in this method since it is where the flag is consumed, Another way is to implement a validate method of RingConfig, and call it from mimir.go
ying-jeanne
force-pushed
the
readinesscheck
branch
from
5999327
to
0f3ed8f
Compare
ying-jeanne
force-pushed
the
readinesscheck
branch
from
5dc37a8
to
302c04a
Compare
pracucci
reviewed
Mar 8, 2023
ying-jeanne
force-pushed
the
readinesscheck
branch
3 times, most recently
from
a8d6b78
to
9f4103b
Compare
|
The CHANGELOG has just been cut to prepare for the next Mimir release. Please rebase |
pracucci
reviewed
Mar 9, 2023
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Grafana Mimir | |||
|
|
|||
| * [CHANGE] Ingester: the configuration parameter `-ingester.ring.readiness-check-ring-health` has been deprecated and will be removed in Mimir 2.9. #4422 | |||
There was a problem hiding this comment.
Contrary to what automatically commented, don't move it outside of 2.7 CHANGELOG because we want to cherry-pick this PR in release 2.7. Just rebase it, please.
pracucci
approved these changes
Mar 9, 2023
ying-jeanne
force-pushed
the
readinesscheck
branch
from
9f4103b
to
083039e
Compare
grafanabot
pushed a commit
that referenced
this pull request
Mar 9, 2023
(cherry picked from commit 9e8e46a)
Merged
aldernero
pushed a commit
that referenced
this pull request
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #4181
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]