Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand unit tests and fix bug for query sharding native histograms #4666

Merged
merged 8 commits into from
Apr 14, 2023
Merged

Expand unit tests and fix bug for query sharding native histograms #4666

merged 8 commits into from
Apr 14, 2023

Conversation

zenador
Copy link
Contributor

@zenador zenador commented Apr 5, 2023 •
edited
Loading

What this PR does

  • Expand unit tests for query sharding native histograms (previously minimal tests, and a few of them were for conventional histograms)
  • Fix bug mentioned in slack: summing a native histogram returns an empty result from query frontend with query sharding, but works as expected from prometheus and querier (you can test the 1st commit in the PR to see the failing updated tests, and then the 2nd commit makes those tests pass)

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zenador zenador requested a review from a team as a code owner April 5, 2023 09:24
@zenador zenador force-pushed the zenador/improve-query-sharding-native-histograms branch 3 times, most recently from a0564fd to 6449bdb Compare April 11, 2023 10:14
@zenador zenador force-pushed the zenador/improve-query-sharding-native-histograms branch from 860344a to 412defd Compare April 12, 2023 09:55
@zenador zenador force-pushed the zenador/improve-query-sharding-native-histograms branch from 521a0af to cb248d4 Compare April 13, 2023 16:52
krajorama
krajorama approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krajorama krajorama merged commit eb5ef3a into main Apr 14, 2023
@krajorama krajorama deleted the zenador/improve-query-sharding-native-histograms branch April 14, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krajorama krajorama krajorama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zenador @krajorama