Commits on Apr 6, 2023

1. store-gateway: report touched postings & series instead of fetched …

   The store-gateway sends statistics about each request in its response to
    the querier. My understanding is that the purpose of these stats is to
    help gauge the cost of a query. Currently, the store-gateway reports
    its fetched bytes. I propose to report touched bytes instead.
   
   __Fetched index bytes__ are based on the number of bytes fetched from
   the bucket. This excludes bytes fetched from the cache and includes bytes overfetched
   because of an incorrect size estimation or when joining adjacent ranges
   from the index object.
   
   __Touched bytes__ are the sum of bytes that were
   directly necessary in order to serve the request. This means that they
   exclude bytes that we overfetched (e.g. when joining adjacent regions of
   an object in the object store or when incorrectly estimating the size of
   a series).
   
   The number of touched bytes should not generally change between query
   executions and will give a better picture of how expensive the query was
   and not depend on cache hit rates or the adjacency of requested regions
   in the index.
   
   Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

   

   dimitarvdimitrov committed Apr 6, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 275ee94
   • Browse repository at this point

   Copy the full SHA

   275ee94 View commit details

   Browse the repository at this point in the history

2. Add changelog entry …

   Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>

   

   dimitarvdimitrov committed Apr 6, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 30e6b68
   • Browse repository at this point

   Copy the full SHA

   30e6b68 View commit details

   Browse the repository at this point in the history