Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the byte size of block metadata when starting a block upload #4683

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

andyasp
Copy link
Contributor

@andyasp andyasp commented Apr 6, 2023

What this PR does

Limits the byte size of block metadata when starting a block upload. This is to prevent a potentially abusive request OOMing the compactor.

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@andyasp andyasp requested a review from a team as a code owner April 6, 2023 19:02
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyasp andyasp force-pushed the aasp/limit-block-metadata-byte-size branch from 8cfb24a to 5afa62d Compare April 6, 2023 19:34
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

pkg/compactor/block_upload.go Outdated Show resolved Hide resolved
pkg/compactor/block_upload.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Remove unnecessary empty line.
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pstibrany pstibrany enabled auto-merge (squash) April 12, 2023 07:35
@pstibrany pstibrany merged commit 091687a into main Apr 12, 2023
19 checks passed
@pstibrany pstibrany deleted the aasp/limit-block-metadata-byte-size branch April 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants