Fix IsFloatHistogram #4706
Merged
Fix IsFloatHistogram #4706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
reviewed
Apr 11, 2023
codesome
requested changes
Apr 11, 2023
Comment on lines
+24
to
+32
| Count: 0, | ||
| ZeroThreshold: 0.001, | ||
| Schema: 2, | ||
| PositiveSpans: []histogram.Span{ | ||
| {Offset: 0, Length: 1}, | ||
| {Offset: 3, Length: 1}, | ||
| {Offset: 2, Length: 2}, | ||
| }, | ||
| PositiveBuckets: []int64{0, 0, 0, 0}, |
There was a problem hiding this comment.
This is an invalid histogram. We should not be supporting this, but rather fixing the source of such histograms. This fix can possibly create more subtle and hard-to-debug bugs. TSDB won't ingest these samples even if given. (in a way, you found out that the count was 0 because of the code assuming it as a float, so it was a good thing IMO that surfaced a bug in histogram generation)
There was a problem hiding this comment.
Ok my bad, I did not see the contents of the bucket, it is indeed valid
codesome
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fix bug mentioned in slack: float histograms are sometimes wrongly interpreted as integer histograms (you can test the 1st commit to see the failing new test, and the 2nd and 3rd commits make that test pass)
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]