Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable protobuf query result payload format by default for rule evaluation path. #4709

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Apr 12, 2023

What this PR does

This PR makes the protobuf format the default for the rule evaluation path, and removes the experimental status on the -ruler.query-frontend.query-result-response-format flag.

Which issue(s) this PR fixes or relates to

#4104

Checklist

  • [n/a] Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@charleskorn charleskorn marked this pull request as ready for review April 12, 2023 01:45
@charleskorn charleskorn requested review from a team as code owners April 12, 2023 01:45
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pracucci pracucci merged commit b66f699 into main Apr 12, 2023
@pracucci pracucci deleted the charleskorn/new-query-result-format-for-ruler branch April 12, 2023 07:07
@lamida lamida mentioned this pull request Apr 17, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants