Improve memory limit on the in-memory cache used for regular expression matchers #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on matchers Signed-off-by: Marco Pracucci <marco@pracucci.com>
dimitarvdimitrov
approved these changes
Apr 17, 2023
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Right. This should address it: c5d2f54 |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
dimitarvdimitrov
approved these changes
Apr 17, 2023
| // the label matchers not comparable with reflect.DeepEqual() so we're going to | ||
| // compare their string representation. | ||
| require.Len(t, decodedMatchers, len(matchers)) | ||
| for i := 0; i < len(matchers); i++ { |
There was a problem hiding this comment.
nit
Suggested change
| for i := 0; i < len(matchers); i++ { | |
| for i := range matchers { |
but if you don't want to wait for CI again, feel free to disregard this
aldernero
pushed a commit
that referenced
this pull request
Apr 17, 2023
…on matchers (#4751) * Improve memory limit on the in-memory cache used for regular expression matchers Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> * Ignore ristretto.Cache goroutines Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix unit tests Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4751-to-release-2.8 origin/release-2.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 020e69d80bfd5ca5f6dfddc9fe341f7aa027f8c9
# Push it to GitHub
git push --set-upstream origin backport-4751-to-release-2.8
git switch main
# Remove the local backport branch
git branch -D backport-4751-to-release-2.8Then, create a pull request where the |
lamida
pushed a commit
that referenced
this pull request
Apr 17, 2023
…on matchers (#4751) * Improve memory limit on the in-memory cache used for regular expression matchers Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> * Ignore ristretto.Cache goroutines Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix unit tests Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 020e69d)
3 tasks
lamida
pushed a commit
that referenced
this pull request
Apr 18, 2023
…on matchers (#4751) * Improve memory limit on the in-memory cache used for regular expression matchers Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> * Ignore ristretto.Cache goroutines Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix unit tests Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 020e69d)
3 tasks
56quarters
pushed a commit
that referenced
this pull request
Apr 18, 2023
…on matchers (#4751) (#4758) * Improve memory limit on the in-memory cache used for regular expression matchers Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed CHANGELOG Signed-off-by: Marco Pracucci <marco@pracucci.com> * Ignore ristretto.Cache goroutines Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fix unit tests Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> (cherry picked from commit 020e69d) Co-authored-by: Marco Pracucci <marco@pracucci.com>
pracucci
pushed a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
added a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Jon Kartago Lamida <jon.lamida@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updating Prometheus to get grafana/mimir-prometheus#482. This will have to be cherry-picked into 2.8 release.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]