Improve packaging start commands #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfriedroset
force-pushed
the
improve-packaging
branch
from
19c9ba7
to
d8b2ba5
Compare
56quarters
approved these changes
Apr 24, 2023
vaxvms
approved these changes
Apr 27, 2023
… to start mimir with a configuration file. Currently mimir is started by systemd with the following command: `/usr/local/bin/mimir --log.level $LOG_LEVEL $CUSTOM_ARGS`. Notice there is not configuration file. It would be more straighforward for the users to have a command with configuration files like this: `/usr/local/bin/mimir --config.file=/etc/mimir/config.yml --runtime-config.file=/etc/mimir/runtime_config.yml --log.level $LOG_LEVEL $CUSTOM_ARGS` `$LOG_LEVEL` and `$CUSTOM_ARGS` comes from `/etc/default/mimir` doing so adds flexibility but scatter the configuration all over the place. Generally the configuration is located in a single file. This single file delivered by the package could be extremely simple or even empty with a like to the configuration. Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
wilfriedroset
force-pushed
the
improve-packaging
branch
from
d8b2ba5
to
dd875f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently mimir is started by systemd with the following command:
/usr/local/bin/mimir --log.level $LOG_LEVEL $CUSTOM_ARGS.Notice there is not configuration file. It would be more straighforward
for the users to have a command with configuration files like this:
/usr/local/bin/mimir --config.file=/etc/mimir/config.yml --runtime-config.file=/etc/mimir/runtime_config.yml --log.level $LOG_LEVEL $CUSTOM_ARGS$LOG_LEVELand$CUSTOM_ARGScomes from/etc/default/mimirdoing soadds flexibility but scatter the configuration all over the place.
Generally the configuration is located in a single file. This single
file delivered by the package could be extremely simple or even empty
with a like to the configuration.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]