Track number of optimised regexp label matchers #4813
Conversation
|
|
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| * [ENHANCEMENT] Go: update to 1.20.3. #4773 | |||
| * [ENHANCEMENT] Store-gateway: reduce memory usage in some LabelValues calls. #4789 | |||
| * [ENHANCEMENT] Store-gateway: add a `stage` label to the metric `cortex_bucket_store_series_data_touched`. This label now applies to `data_type="chunks"` and `data_type="series"`. The `stage` label has 2 values: `processed` - the number of series that parsed - and `returned` - the number of series selected from the processed bytes to satisfy the query. #4797 | |||
| * [ENHANCEMENT] Query-frontend: track number of optimised regexp label matchers. #4813 | |||
There was a problem hiding this comment.
| * [ENHANCEMENT] Query-frontend: track number of optimised regexp label matchers. #4813 | |
| * [ENHANCEMENT] Query-frontend: Add `cortex_frontend_regexp_matcher_count` and `cortex_frontend_regexp_matcher_optimized_count` metrics to track optimization of regular expression label matchers. #4813 |
There was a problem hiding this comment.
Thanks for working on this! My only comment is that that way it's implemented means it gets tracked only for tenants with query sharding enabled. I think we should track for every query. For this reason, I think a better place where to place this logic is pkg/frontend/querymiddleware/stats.go. You will need to parse the query there again (in a follow up PR we can do a refactoring to parse the query once and pass around the parsed query along with the Request).
dhanusaputra
force-pushed
the
track-number-of-optimised-regexp-label-matchers
branch
from
a773221
to
48dca36
Compare
|
test:
|
Signed-off-by: dhanu <andreasdhanu@gmail.com>
dhanusaputra
force-pushed
the
track-number-of-optimised-regexp-label-matchers
branch
from
cfdaa8d
to
1311a66
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
I pushed a commit 5b6e6f9 to ignore any parsing error in |
|
@dhanusaputra could you sign the CLA (see message above)? Otherwise we can't merge this PR. |
What this PR does
longestRegexpMatcherBytesso it can return more dataWhich issue(s) this PR fixes or relates to
Fixes #4638
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]