Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingester.md #4827

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Update ingester.md #4827

merged 2 commits into from
Apr 27, 2023

Conversation

willychrisza
Copy link
Contributor

minor changes for clarity

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

minor changes for clarity
@willychrisza willychrisza added type/docs Improvements or additions to documentation Q1SE labels Apr 24, 2023
@willychrisza willychrisza requested review from a team as code owners April 24, 2023 18:38
@CLAassistant
Copy link

CLAassistant commented Apr 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@osg-grafana osg-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs doc review

@dimitarvdimitrov
Copy link
Contributor

the changes seem ok and correct, but I'm not sure if we want to break the consistency with the other components - the title is Grafana Mimir <component> whereas this changes it to Understanding <component>.

Also if we do decide to go with the new format, it will be great if we don't break existing links.

Co-authored-by: Ursula Kallio <ursula.kallio@grafana.com>
@pracucci
Copy link
Collaborator

Thanks for contributing to doc! I committed the Ursula's edits to move forward with this PR. @osg-grafana can you take a final look, please?

@56quarters 56quarters merged commit 0552915 into main Apr 27, 2023
@56quarters 56quarters deleted the willychrisza-patch-1 branch April 27, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants