Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP timeout on block upload endpoint for uploading a file. #4956

Merged
merged 11 commits into from
May 10, 2023

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented May 9, 2023

This PR disables HTTP timeout values on compactor's endpoint for uploading a file for a block. This is done to allow uploads of big files.

In the future we may want to introduce minimum upload rate instead of just disabling timeout.

Note that block upload feature is disabled by default, and must be enabled for tenant to use it.

This PR also changes /api/v1/upload/block/{block}/files endpoint to allow upload of files with unset Content-Length (chunked uploads).

@pstibrany pstibrany mentioned this pull request May 9, 2023
3 tasks
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Log errors sent back to client from file upload handler.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…imeouts disabled.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany changed the title WIP: Fixing backfill timeouts Disable HTTP timeout on block upload endpoint for uploading a file. May 10, 2023
@pstibrany pstibrany marked this pull request as ready for review May 10, 2023 07:54
@pstibrany pstibrany requested a review from a team as a code owner May 10, 2023 07:54
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration test, LGTM! 👏

CHANGELOG.md Outdated Show resolved Hide resolved
pstibrany and others added 2 commits May 10, 2023 11:44
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
@pstibrany
Copy link
Member Author

pstibrany commented May 10, 2023

Nice integration test, LGTM! 👏

Thank you for review! This test was @andyasp's idea.

@pstibrany pstibrany merged commit c9bdfe3 into main May 10, 2023
19 checks passed
@pstibrany pstibrany deleted the backfill-timeouts branch May 10, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants