store-gateway: reduce series size estimation #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 64KiB size estimation for series was inherited from Thanos. The PR which adds this to Thanos didn't give any explanation for why 64KiB was chosen. Based on some rough estimation we think that we can bring this number down in order to reduce the volume of fetched data. Citing Marco > Assuming a worst case scenario of 1 sample /sec, in a 24h block we have 744 chunks per series. > The worst case scenario of each meta ref is 8*3=24 bytes, so 744*24 = 17856 bytes. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Related to #4593
The 64KiB size estimation for series was inherited from Thanos. The PR which adds this to Thanos (PR 1985) didn't give any explanation for why 64KiB was chosen. Based on some rough estimation we think that we can bring this number down in order to reduce the volume of fetched data.
Citing @pracucci
This PR also moves this constant to the tsdb package which contains similar constants.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]