Ingester shutdown marker improvements #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the way shutdown markers for ingesters work. Namely it: * Removes the shutdown marker while shutting down. The volumes used by ingesters are reused if an ingester is stopped (scaled down) but then later started again with the same name. Removing the marker during shutdown prevents the ingester from unregistering and flushing the next time it is stopped after having already performed its work for "permanently" shutting down. * Prevents changes to the shutdown marker while the ingester is not running. This prevents the rollout-operator from calling the `prepare-shutdown` endpoint again while the ingester is already in the process of shutting down and about to remove the shutdown marker as noted previously. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
pracucci
reviewed
May 11, 2023
…oint Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
pracucci
reviewed
May 15, 2023
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR improves the way shutdown markers for ingesters work. Namely it:
prepare-shutdownendpoint again while the ingester is already in the process of shutting down and about to remove the shutdown marker as noted previously.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]