Fix returned status code on max samples limit hit when query sharding is enabled #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is enabled Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Nov 16, 2021
pracucci
commented
Nov 16, 2021
| @@ -823,12 +823,6 @@ func TestQuerySharding_ShouldReturnErrorInCorrectFormat(t *testing.T) { | |||
| expError: apierror.New(apierror.TypeTimeout, "query timed out in expression evaluation"), | |||
| queryable: queryableSlow, | |||
| }, | |||
| { | |||
| name: "downstream - sample limit", | |||
There was a problem hiding this comment.
Removed because was a duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While running some tests in a cluster with query sharding enabled, I've noticed that when the "max samples limit" is reached the returned status code is 5xx instead of 422 (as done by Prometheus). The API errors mapping was fixed in #360 but we forgot to handle the
promql.ErrTooManySamplesso this PR fixes that case.Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]