store-gateway: limit number of values in LabeValues cache items #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encoding/gob has a bug when decoding string slices that are longer than 655360 items. This PR introduces a hard limit on the number of items in a cache item that we store. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
approved these changes
May 16, 2023
dimitarvdimitrov
deleted the
dimitar/st-gw/limit-label-values-item-count-limit
branch
We should purge the cache by changing the cache key for this. |
3 tasks
I opened #5037 to change the cache key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
encoding/gob has a bug when decoding string slices that are longer than 655360 items. This PR introduces a hard limit on the number of items in a cache item that we store.
Which issue(s) this PR fixes or relates to
Fixes #5014
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]