Promote some experimental features to stable for release 2.9 #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxbk
commented
Jun 1, 2023
flxbk
changed the title
flxbk
changed the title
flxbk
force-pushed
the
felix/stable-features-2.9
branch
from
16fd246
to
bfe194a
Compare
flxbk
force-pushed
the
felix/stable-features-2.9
branch
from
c22f6a6
to
13b0db8
Compare
flxbk
commented
Jun 1, 2023
| "-compactor.ring.wait-stability-max-duration": "0", | ||
| "-compactor.ring.wait-stability-min-duration": "0", | ||
| "-compactor.ring.wait-stability-max-duration": "0", | ||
| "-compactor.first-level-compaction-wait-period": "0s", |
There was a problem hiding this comment.
This is needed to unbreak TestCompactBlocksContainingNativeHistograms, which apparently expects this value to be lower than the new default.
There was a problem hiding this comment.
I think this is fine to not slow down the test.
krajorama
reviewed
Jun 2, 2023
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Let's mention the jsonnet query sharding target series per shard new default in the jsonnet section.
Similarly for helm but in its own changelog file.
krajorama
reviewed
Jun 2, 2023
krajorama
approved these changes
Jun 2, 2023
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>
flxbk
added a commit
that referenced
this pull request
Jun 5, 2023
* Increase linter timeout. (#5159) * Bump actions/setup-go from 3 to 4 (#5142) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Jsonnet: Update rollout-operator to v0.6.0 (#5155) * Jsonnet: Update rollout-operator to v0.6.0 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Changelog Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Test updates Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> --------- Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> * Jsonnet: remove $._config.querier.replicas and $._config.queryFrontend.replicas (#5131) * Jsonnet: remove $._config.querier.replicas and $._config.queryFrontend.replicas Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update CHANGELOG.md Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> * Promote some experimental features to stable for release 2.9 (#5128) * Declare -query-frontend.query-sharding-max-regexp-size-bytes stable * Declare -query-scheduler.max-used-instances stable * Declare -(alertmanager|blocks|ruler)-storage.storage-prefix stable * Declare -compactor.first-level-compaction-wait-period stable * Declare -usage-stats.* stable * Declare -query-frontend.query-sharding-target-series-per-shard stable * Update docs * Update changelog * Update changelogs * Update operations/helm/charts/mimir-distributed/CHANGELOG.md Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> * Add missing entries for 2.9 to CHANGELOG.md (#5127) * Add missing entries for 2.9 to CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update CHANGELOG.md Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> --------- Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> * Cut changelog for Mimir 2.9 (#5167) * Changed default of -ruler.poll-interval from 1m to 10m (#5171) Signed-off-by: Marco Pracucci <marco@pracucci.com> * Add dashboard screenshots for Mimir 2.9 (#5168) --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com> Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Charles Korn <charleskorn@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nick Pillitteri <56quarters@users.noreply.github.com> Co-authored-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This promotes the following features/options from experimental to stable:
-query-frontend.query-sharding-max-regexp-size-bytes-query-scheduler.max-used-instances-(alertmanager|blocks|ruler)-storage.storage-prefix-compactor.first-level-compaction-wait-period-usage-stats.*-query-frontend.query-sharding-target-series-per-shardIt also adds a non-default value of
2500for the-query-frontend.query-sharding-target-series-per-shardflag in Jsonnet and Helm. We've obtained good results from this setting internally at Grafana Labs, but enabling it by default would imply enabling the results cache by default, which we don't want to do.Individual commits are self-contained to make review easier.
Which issue(s) this PR fixes or relates to
Related to #5112
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]