Remove cortex_query_frontend_workers_enqueued_requests_total metric #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
force-pushed
the
remove-cortex_query_frontend_workers_enqueued_requests_total
branch
from
4a7ba48
to
d9992ef
Compare
3 tasks
pracucci
force-pushed
the
remove-cortex_query_frontend_workers_enqueued_requests_total
branch
from
d9992ef
to
8d99ba6
Compare
3 tasks
charleskorn
approved these changes
Sep 26, 2023
pracucci
force-pushed
the
track-query-frontend-enqueue-duration-per-query-scheduler
branch
from
a78e6ce
to
a1d515a
Compare
Base automatically changed from
track-query-frontend-enqueue-duration-per-query-scheduler
to
main
September 26, 2023 14:51
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
remove-cortex_query_frontend_workers_enqueued_requests_total
branch
from
8d99ba6
to
f9767a9
Compare
pracucci
deleted the
remove-cortex_query_frontend_workers_enqueued_requests_total
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We recently introduced
cortex_query_frontend_enqueue_duration_seconds(histogram) for the query-frontend even when the query-scheduler is in use. This makes thecortex_query_frontend_workers_enqueued_requests_totalobsolete, becausecortex_query_frontend_enqueue_duration_seconds_countcan be used instead ofcortex_query_frontend_workers_enqueued_requests_total.In this PR I propose to remove
cortex_query_frontend_workers_enqueued_requests_totalmetric. I checked alerts and dashboards, and it doesn't look to be used anywhere.This PR builds on #6120.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]