Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cardinality API qps to Overview dashboard #6720

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

flxbk
Copy link
Contributor

@flxbk flxbk commented Nov 23, 2023

What this PR does

This adds requests to the /api/v1/cardinality/... endpoints to the Overview dashboard. Series for requests in this category will only be displayed if there have been any requests in the selected time frame.

image

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about displaying all cardinality requests there under one category? Currently cardinality label values and names is missing.

@flxbk flxbk force-pushed the felix/dashboard-active-series branch from d581024 to e3f3360 Compare February 13, 2024 14:12
@flxbk
Copy link
Contributor Author

flxbk commented Feb 13, 2024

WDYT about displaying all cardinality requests there under one category?

what do you mean by "under one category"?

@dimitarvdimitrov
Copy link
Contributor

WDYT about displaying all cardinality requests there under one category?

what do you mean by "under one category"?

I think I meant having just a single line in the graph for all of them

@flxbk flxbk marked this pull request as ready for review February 16, 2024 12:21
@flxbk flxbk requested a review from a team as a code owner February 16, 2024 12:21
@flxbk
Copy link
Contributor Author

flxbk commented Feb 16, 2024

If there's any issue caused by a particular type of request I think it could be helpful to get an immediate visual breakdown by request type instead of having different types lumped into the same category. WDYT about adding > 0 to the other (cardinality API) types as well to avoid cluttering the panel legend?

@dimitarvdimitrov
Copy link
Contributor

If there's any issue caused by a particular type of request I think it could be helpful to get an immediate visual breakdown by request type instead of having different types lumped into the same category. WDYT about adding > 0 to the other (cardinality API) types as well to avoid cluttering the panel legend?

sounds like a good middle ground 👍

@flxbk flxbk force-pushed the felix/dashboard-active-series branch from e3f3360 to 4a85d89 Compare February 25, 2024 12:22
@flxbk
Copy link
Contributor Author

flxbk commented Feb 25, 2024

I have added the other cardinality endpoints as well.

@flxbk flxbk changed the title Add "active series" qps to Overview dashboard Add cardinality API qps to Overview dashboard Feb 25, 2024
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flxbk flxbk merged commit 559a1db into main Feb 27, 2024
30 checks passed
@flxbk flxbk deleted the felix/dashboard-active-series branch February 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants