-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cardinality API qps to Overview dashboard #6720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about displaying all cardinality requests there under one category? Currently cardinality label values and names is missing.
d581024
to
e3f3360
Compare
what do you mean by "under one category"? |
I think I meant having just a single line in the graph for all of them |
If there's any issue caused by a particular type of request I think it could be helpful to get an immediate visual breakdown by request type instead of having different types lumped into the same category. WDYT about adding |
sounds like a good middle ground 👍 |
e3f3360
to
4a85d89
Compare
I have added the other cardinality endpoints as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does
This adds requests to the
/api/v1/cardinality/...
endpoints to the Overview dashboard. Series for requests in this category will only be displayed if there have been any requests in the selected time frame.Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.