Rename "ring" to "ingester ring" #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- field in `pkg/mimir/Mimir` - init method - module name Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
4 tasks
ying-jeanne
approved these changes
Nov 28, 2023
pracucci
approved these changes
Nov 28, 2023
| @@ -67,7 +67,7 @@ const ( | |||
| ActivityTracker string = "activity-tracker" | |||
| API string = "api" | |||
| SanityCheck string = "sanity-check" | |||
| Ring string = "ring" | |||
| IngesterRing string = "ingester-ring" | |||
There was a problem hiding this comment.
Note to reviewers: I think this is not a breaking change because the module is configured as modules.UserInvisibleModule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is small internal refactoring that renames field, init method and module name from "ring" to "ingester ring", since we now have many other rings too.
Which issue(s) this PR fixes or relates to
Fixes comment #6718 (comment).
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.