Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where failed remote rule evaluation errors are logged without context such as trace IDs #6789

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR fixes an issue where the "failed to remotely evaluate query expression, will retry" message is logged without context such as the trace ID. This also fixes the issue where these messages are not recorded as trace events.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review December 1, 2023 02:20
@charleskorn charleskorn requested review from a team as code owners December 1, 2023 02:20
@charleskorn charleskorn merged commit 874ea9c into main Dec 1, 2023
28 checks passed
@charleskorn charleskorn deleted the charleskorn/ruler-logging branch December 1, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants